It is currently Tue Dec 12, 2017 10:39 am

All times are UTC - 7 hours





Post new topic Reply to topic  [ 11 posts ] 
Author Message
PostPosted: Tue Jun 01, 2010 1:54 pm 
Offline
User avatar

Joined: Sun Sep 19, 2004 9:28 pm
Posts: 3192
Location: Mountain View, CA, USA
Since upgrading to PHP 5.3, the following warning was being thrown:

Warning: Parameter 1 to Language::getMagic() expected to be a reference, value given in /home/ndwiki/www/w/includes/StubObject.php on line 58

Bug reference: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/55429

Looks like a one-line fix (removal of "&" character (reference declaration) in the function argument).

Since the fix is only available in MediaWiki 1.6 -- which isn't out yet -- I decided to modify www/w/languages/Language.php to include the one-line fix.


Top
 Profile  
 
 Post subject:
PostPosted: Tue Jun 01, 2010 3:36 pm 
Offline
User avatar

Joined: Tue Jun 24, 2008 8:38 pm
Posts: 1519
Location: Fukuoka, Japan
Thanks for the fix.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Jun 02, 2010 7:14 pm 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19335
Location: NE Indiana, USA (NTSC)
It appears that the reCAPTCHA also needs to be updated for PHP 5.3; otherwise, no changes to a page can be saved.
Quote:
Warning: Parameter 1 to ReCaptcha::confirmEdit() expected to be a reference, value given in /home/ndwiki/www/w/includes/Hooks.php on line 117
Internal error
From Nesdev wiki
Jump to: navigation, search

Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 03, 2010 8:38 am 
Offline
User avatar

Joined: Sun Sep 19, 2004 9:28 pm
Posts: 3192
Location: Mountain View, CA, USA
Nice catch tepples. I'll see what I can dig up on that.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 03, 2010 9:47 am 
Offline
User avatar

Joined: Sun Sep 19, 2004 9:28 pm
Posts: 3192
Location: Mountain View, CA, USA
One-line fix for extensions/recaptcha/ReCaptcha.php. Includes line numbers:

Old code:

Code:
    100         function confirmEdit( &$editPage, $newtext, $section ) {


New code:
Code:
    100         function confirmEdit( $editPage, $newtext, $section ) {


Can you test again, tepples? I was able to do an update but I wasn't prompted for the captcha.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 03, 2010 11:08 am 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19335
Location: NE Indiana, USA (NTSC)
koitsu wrote:
Can you test again, tepples? I was able to do an update but I wasn't prompted for the captcha.

The CAPTCHA happens only if you register or add an external link. (Wikipedia disables CAPTCHA for "autoconfirmed" users with 4 days and 10 edits; nesdevWiki appears not to.) This edit went through.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 03, 2010 12:33 pm 
Offline
User avatar

Joined: Sun Sep 19, 2004 9:28 pm
Posts: 3192
Location: Mountain View, CA, USA
Cool, thanks much! I'll add something on my blog about said bug/issue + the fix, so others on the 'net can fix their stuff. I couldn't find anything on the reCAPTCHA forum about it.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Jun 03, 2010 3:03 pm 
Offline
User avatar

Joined: Tue Jun 24, 2008 8:38 pm
Posts: 1519
Location: Fukuoka, Japan
Good to see that it was fixed. I checked the plug-in web page (very fast) and there was no mention about this.


Top
 Profile  
 
 Post subject:
PostPosted: Fri Jun 04, 2010 9:10 am 
Offline
User avatar

Joined: Sun Sep 19, 2004 9:28 pm
Posts: 3192
Location: Mountain View, CA, USA
http://koitsu.wordpress.com/2010/06/04/mediawiki-and-recaptcha-fixes-for-php-5-3/

That's all folks.


Top
 Profile  
 
 Post subject:
PostPosted: Fri Jun 04, 2010 3:11 pm 
Offline
User avatar

Joined: Tue Jun 24, 2008 8:38 pm
Posts: 1519
Location: Fukuoka, Japan
It seems to be working... Since the spammers were able to add some link :lol: I don't now why those human spammer for essays seems to target the nesdev wiki. duh.

edit:

In a way I know why to put link to random site: just to increase their SEO on google since they don't link back to our site. Wiki are easy targets..


Top
 Profile  
 
 Post subject:
PostPosted: Fri Jun 04, 2010 5:49 pm 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19335
Location: NE Indiana, USA (NTSC)
Banshaku wrote:
Wiki are easy targets..

Only if they're not monitored for recent changes.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 11 posts ] 

All times are UTC - 7 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group