nesdev.com
http://forums.nesdev.com/

6502 NES disassembler, python 3
http://forums.nesdev.com/viewtopic.php?f=2&t=15674
Page 2 of 2

Author:  dougeff [ Wed Apr 05, 2017 1:28 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

https://github.com/nesdoug

There. Is that better for you?

Author:  mikejmoffitt [ Wed Apr 05, 2017 3:26 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

Thanks for uploading. I've made a few suggestions: https://github.com/nesdoug/NES-DISASSEMBLER/pull/1

Author:  dougeff [ Wed Apr 05, 2017 3:55 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

I'm new to github. I'm not sure the etiquette. Am I expected to merge your changes, or leave it as a separate fork?


Also, I never mentioned it, but the reason my disassembler won't output an absolute address in the zero page (instead outputs 3 bytes)...is asm6 always converts this to a zero page address, and it won't reassemble the same.

Example
LDA $0034

Becomes
.hex AD 34 00

Author:  tepples [ Wed Apr 05, 2017 4:36 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

Dunno about asm6, but in ca65 you can force absolute addressing with lda a:$34.

Author:  tokumaru [ Wed Apr 05, 2017 6:08 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

No way to force absolute addressing in ASM6, AFAIK. When I need that, I either type the instruction in hex (with the original instruction as a comment to make my intention clear) or I use a mirror (Variable+$800).

Author:  mikejmoffitt [ Thu Apr 06, 2017 11:33 am ]
Post subject:  Re: 6502 NES disassembler, python 3

dougeff wrote:
I'm new to github. I'm not sure the etiquette. Am I expected to merge your changes, or leave it as a separate fork?


Also, I never mentioned it, but the reason my disassembler won't output an absolute address in the zero page (instead outputs 3 bytes)...is asm6 always converts this to a zero page address, and it won't reassemble the same.

Example
LDA $0034

Becomes
.hex AD 34 00

What you'd do on GitHub (and with collaboration-based source control in general) is review the changes on the pull request first. If you like the changes as-is, you may accept them and merge them. Otherwise (and more typically) you leave comments about what you'd want changed before you accept it.

In my case, I goofed a little, and allowed git to convert the line endings to unix-style, as opposed to the windows-style you had before, so the entire file appears to be changed even though I did not make such sweeping changes. Nothing will break here, since it will be converted back for you as you check it out in Git for Windows, but it makes the pull request review very difficult.

Author:  rainwarrior [ Thu Apr 06, 2017 12:06 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

Since we're talking about github etiquette, usually the onus is on the person making the pull request to provide an easily reviewable change. ;)

i.e. you should fix the line endings in your pull request branch, rather than requiring the puller to fix it.

Not that I think it matters or is a big deal in this specific case, but dougeff was asking about github etiquette.

Author:  mikejmoffitt [ Thu Apr 06, 2017 12:19 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

rainwarrior wrote:
Since we're talking about github etiquette, usually the onus is on the person making the pull request to provide an easily reviewable change. ;)

i.e. you should fix the line endings in your pull request branch, rather than requiring the puller to fix it.

Not that I think it matters or is a big deal in this specific case, but dougeff was asking about github etiquette.


Right, that's why I've acknowledged my mistake repeatedly, and worked on fixing it :?

Author:  rainwarrior [ Thu Apr 06, 2017 12:58 pm ]
Post subject:  Re: 6502 NES disassembler, python 3

Sorry, wasn't trying to cast shame on you or anything, I know you're fixing it, just wanted to illustrate the point about open source etiquette and thought it made a suitable example.

Page 2 of 2 All times are UTC - 7 hours
Powered by phpBB® Forum Software © phpBB Group
http://www.phpbb.com/