It is currently Sat Oct 21, 2017 1:15 am

All times are UTC - 7 hours





Post new topic Reply to topic  [ 23 posts ]  Go to page Previous  1, 2
Author Message
PostPosted: Sun Aug 27, 2017 1:31 pm 
Offline
User avatar

Joined: Wed Oct 16, 2013 7:55 am
Posts: 130
I apologize, it was mostly out of frustration that I'd have to relearn git-svn and manage to update code without ruining some private branches. Did not mean any derision against the FCEUX maintainers.


Top
 Profile  
 
PostPosted: Sun Aug 27, 2017 7:10 pm 
Offline
User avatar

Joined: Wed Oct 16, 2013 7:55 am
Posts: 130
The fix was really simple. I submitted an issue and the fix at https://sourceforge.net/p/fceultra/bugs/804/ in case anyone is interested. Patch is attached in case you want to build from source yourself.


Attachments:
ntsc-close.patch [875 Bytes]
Downloaded 20 times
Top
 Profile  
 
PostPosted: Sun Aug 27, 2017 7:25 pm 
Offline
User avatar

Joined: Sun Jan 22, 2012 12:03 pm
Posts: 5728
Location: Canada
Thanks for the patch. I pushed it through.


Top
 Profile  
 
PostPosted: Sun Aug 27, 2017 7:49 pm 
Offline
User avatar

Joined: Sat Feb 12, 2005 9:43 pm
Posts: 10065
Location: Rio de Janeiro - Brazil
Cool! Thanks a bunch guys, for working on this!


Top
 Profile  
 
PostPosted: Mon Aug 28, 2017 1:34 am 
Offline

Joined: Tue Oct 06, 2015 10:16 am
Posts: 558
tepples wrote:
What's the practical difference between a diff -ub attachment to an issue in an issue tracker and a pull request in a web frontend to Git, other than that the latter has automatic checking for whether it merges cleanly?

Laziness, every additional step discourages contribution.

That said, scons is also a barrier, it's a terrible build system that almost nobody uses, but perhaps I'm in the minority with this opinion.


Top
 Profile  
 
PostPosted: Mon Aug 28, 2017 5:23 am 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19113
Location: NE Indiana, USA (NTSC)
calima wrote:
tepples wrote:
What's the practical difference between a diff -ub attachment to an issue in an issue tracker and a pull request in a web frontend to Git, other than that the latter has automatic checking for whether it merges cleanly?

Laziness, every additional step discourages contribution.

Everything's a step, including the choice of repository host. For example, FCEUX not following the masses from SourceForge to GitHub introduces a step because potential contributors are more likely to already have only a GitHub account and thus have to register for SourceForge. Or a different project using GitLab or Savannah when a particular contributor uses GitHub or Bitbucket or SourceForge also introduces a step. But some more purist projects consider it an essential one because GitHub and SourceForge don't work unless a user whitelists the site's proprietary JavaScript.


Top
 Profile  
 
PostPosted: Sun Sep 10, 2017 1:05 pm 
Offline

Joined: Sun Jun 12, 2011 12:06 pm
Posts: 218
Location: Poland
I had the problem with crashing on FCEUX when I was playing with adding new mappers and launched newly produced INES 2.0 ROM with CHR-ROM banks set to 0 and CHR-RAM size in INES2.0 part also set to 0.


Top
 Profile  
 
PostPosted: Mon Sep 11, 2017 1:58 pm 
Offline
User avatar

Joined: Sat Jul 12, 2014 3:04 pm
Posts: 936
huh, I presumed they'd already implemented Magic Floor's CHRless mapper (the one using the CIRAM as CHR)?

Why [else] would you want CHRless?


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 23 posts ]  Go to page Previous  1, 2

All times are UTC - 7 hours


Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group