It is currently Mon Sep 25, 2017 10:06 am

All times are UTC - 7 hours





Post new topic Reply to topic  [ 13 posts ] 
Author Message
PostPosted: Wed Jun 24, 2015 7:22 am 
Online
User avatar

Joined: Mon Jan 03, 2005 10:36 am
Posts: 2950
Location: Tampere, Finland
Today I learned that the DPCM samples in Shadow Warriors (the European version of Ninja Gaiden) are messed up somehow (compared to the U.S. version). Namely the snare sample is replaced by a strange "pop" sound that sounds more like a bass drum, and the bass drum sample is replaced by something that sounds like a short piece of noise.

Did anyone ever look into why this happens? It seems like something that might be caused by a bug such as a wrong sample start offset being used.

Also noteworthy is that the NSF rip of Shadow Warriors is "broken" in that it sounds better than it should. Maybe because the rip was hacked on top of the original Ninja Gaiden rip: viewtopic.php?p=49363#p49363

EDIT: For comparison:
Ninja Gaiden: https://youtu.be/DIcOjUaf5P8?t=11
Shadow Warriors: https://youtu.be/3c_8J5BHkiQ?t=15

_________________
Download STREEMERZ for NES from fauxgame.com! — Some other stuff I've done: kkfos.aspekt.fi


Top
 Profile  
 
PostPosted: Wed Jun 24, 2015 10:48 am 
Offline

Joined: Sun Apr 13, 2008 11:12 am
Posts: 6183
Location: Seattle
They flat-out forgot to include the drum DPCMs into the Shadow Warriors image. Probably because the fixed bank grew a little, overlapping with where the DPCM would have been.

(The game runs in 16+16F banking for the entire time)

The two DPCM samples start at $FC00, or 0x1FC10 in the iNES file. In Shadow Warriors, it's got code all the way up to $FDBD...


Top
 Profile  
 
PostPosted: Wed Jun 24, 2015 11:31 pm 
Online
User avatar

Joined: Mon Jan 03, 2005 10:36 am
Posts: 2950
Location: Tampere, Finland
Yeah, looks to be like that. Unfortunately no easy way to patch it since the samples take 768 bytes but only 512 bytes are free in the Shadow Warriors fixed bank. I guess an authentic NSF rip would be still good to have.

_________________
Download STREEMERZ for NES from fauxgame.com! — Some other stuff I've done: kkfos.aspekt.fi


Top
 Profile  
 
PostPosted: Thu Jun 25, 2015 3:16 am 
Offline
User avatar

Joined: Fri Nov 12, 2004 2:49 pm
Posts: 7213
Location: Chexbres, VD, Switzerland
God it sounds awful. Once again, it's terrible how Nintendo depicted their Euoprean customers...


Top
 Profile  
 
PostPosted: Thu Jun 25, 2015 12:07 pm 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19015
Location: NE Indiana, USA (NTSC)
thefox wrote:
Unfortunately no easy way to patch it since the samples take 768 bytes but only 512 bytes are free in the Shadow Warriors fixed bank.

Can you change the sound effects engine to add two more sound effects "kick" and "snare" and have it play those instead of samples?


Top
 Profile  
 
PostPosted: Thu Jun 25, 2015 12:35 pm 
Offline

Joined: Sun Apr 13, 2008 11:12 am
Posts: 6183
Location: Seattle
There's clearly-unused bytes in Shadow Warriors from $FDC0-$FFBF. It tentatively feels to me like the least-invasive injection would be to shrink both the snare (512? bytes) and bd sample (256? bytes) by 128 bytes each and stuff them in the remaining free space.

It might also be practical to resample two samples from the 33kHz (rate $F) that Ninja Gaiden uses down to 21kHz (rate $D) to make it fit... Maybe?

Both builds put the MMC1-power-on-reset at $FFDA, which could be moved to free up some space, but... Shadow Warriors has some funny code from $FFC0-FFD4, but I'm not certain what ever calls it. (Obviously it could be called indirectly, but at least JSR $FFC0 and JMP $FFC0 don't appear in the PRG.)


Top
 Profile  
 
PostPosted: Sun Jun 28, 2015 2:01 pm 
Offline
User avatar

Joined: Thu Sep 07, 2006 1:08 pm
Posts: 532
Location: United States
lidnariq wrote:
They flat-out forgot to include the drum DPCMs into the Shadow Warriors image. Probably because the fixed bank grew a little, overlapping with where the DPCM would have been.

A week before the game ships:

"Hey guys! I, uh... accidentally wrote over some code." :lol:

_________________
Ruling the World One Bean™ at a Time...


Top
 Profile  
 
PostPosted: Wed Jul 01, 2015 3:43 pm 
Offline
User avatar

Joined: Fri Jan 24, 2014 9:05 am
Posts: 129
Location: Hungary
lidnariq wrote:
There's clearly-unused bytes in Shadow Warriors from $FDC0-$FFBF. It tentatively feels to me like the least-invasive injection would be to shrink both the snare (512? bytes) and bd sample (256? bytes) by 128 bytes each and stuff them in the remaining free space.
It might also be practical to resample two samples from the 33kHz (rate $F) that Ninja Gaiden uses down to 21kHz (rate $D) to make it fit... Maybe?


If you take the snare sample and chop off the second 256 bytes, it sounds awfully similar to one of the snares found in Konami games... for example: Bucky o' Hare and Lagrange Point. I think people would be content with that.


Top
 Profile  
 
PostPosted: Thu Jul 02, 2015 2:18 am 
Online
User avatar

Joined: Mon Jan 03, 2005 10:36 am
Posts: 2950
Location: Tampere, Finland
Just my opinion, but I'm not a fan of half-assed fixes, like truncating samples or replacing samples with sound effects.

_________________
Download STREEMERZ for NES from fauxgame.com! — Some other stuff I've done: kkfos.aspekt.fi


Top
 Profile  
 
PostPosted: Tue Oct 04, 2016 11:44 am 
Offline
User avatar

Joined: Tue May 06, 2014 1:50 pm
Posts: 303
Location: Szeged, Hungary
LOL.

I just swapped the 1C010-20000 region replacing the code with the US version's code, and it works like it should have been, so after this I seriously don't know how they were able to screw this up.

[Removed Shadow Warriors Fix.yarr --MOD]

_________________
http://mrnorbert1994.uw.hu/


Top
 Profile  
 
PostPosted: Tue Oct 04, 2016 3:41 pm 
Offline
User avatar

Joined: Sun Jan 22, 2012 12:03 pm
Posts: 5650
Location: Canada
What's a "yarr" file?


Top
 Profile  
 
PostPosted: Tue Oct 04, 2016 4:17 pm 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19015
Location: NE Indiana, USA (NTSC)
RAR containing a pirated copy of the ROM.


Top
 Profile  
 
PostPosted: Tue Oct 04, 2016 6:54 pm 
Offline
User avatar

Joined: Sat Jul 12, 2014 3:04 pm
Posts: 936
:lol: Never change, Tepples.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 13 posts ] 

All times are UTC - 7 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group