It is currently Tue Oct 17, 2017 1:34 pm

All times are UTC - 7 hours





Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2
Author Message
PostPosted: Wed Apr 05, 2017 1:28 pm 
Offline
User avatar

Joined: Fri May 08, 2015 7:17 pm
Posts: 1770
Location: DIGDUG
https://github.com/nesdoug

There. Is that better for you?

_________________
nesdoug.com -- blog/tutorial on programming for the NES


Top
 Profile  
 
PostPosted: Wed Apr 05, 2017 3:26 pm 
Offline
User avatar

Joined: Sun May 27, 2012 8:43 pm
Posts: 1304
Thanks for uploading. I've made a few suggestions: https://github.com/nesdoug/NES-DISASSEMBLER/pull/1


Top
 Profile  
 
PostPosted: Wed Apr 05, 2017 3:55 pm 
Offline
User avatar

Joined: Fri May 08, 2015 7:17 pm
Posts: 1770
Location: DIGDUG
I'm new to github. I'm not sure the etiquette. Am I expected to merge your changes, or leave it as a separate fork?


Also, I never mentioned it, but the reason my disassembler won't output an absolute address in the zero page (instead outputs 3 bytes)...is asm6 always converts this to a zero page address, and it won't reassemble the same.

Example
LDA $0034

Becomes
.hex AD 34 00

_________________
nesdoug.com -- blog/tutorial on programming for the NES


Top
 Profile  
 
PostPosted: Wed Apr 05, 2017 4:36 pm 
Offline

Joined: Sun Sep 19, 2004 11:12 pm
Posts: 19087
Location: NE Indiana, USA (NTSC)
Dunno about asm6, but in ca65 you can force absolute addressing with lda a:$34.


Top
 Profile  
 
PostPosted: Wed Apr 05, 2017 6:08 pm 
Offline
User avatar

Joined: Sat Feb 12, 2005 9:43 pm
Posts: 10046
Location: Rio de Janeiro - Brazil
No way to force absolute addressing in ASM6, AFAIK. When I need that, I either type the instruction in hex (with the original instruction as a comment to make my intention clear) or I use a mirror (Variable+$800).


Top
 Profile  
 
PostPosted: Thu Apr 06, 2017 11:33 am 
Offline
User avatar

Joined: Sun May 27, 2012 8:43 pm
Posts: 1304
dougeff wrote:
I'm new to github. I'm not sure the etiquette. Am I expected to merge your changes, or leave it as a separate fork?


Also, I never mentioned it, but the reason my disassembler won't output an absolute address in the zero page (instead outputs 3 bytes)...is asm6 always converts this to a zero page address, and it won't reassemble the same.

Example
LDA $0034

Becomes
.hex AD 34 00

What you'd do on GitHub (and with collaboration-based source control in general) is review the changes on the pull request first. If you like the changes as-is, you may accept them and merge them. Otherwise (and more typically) you leave comments about what you'd want changed before you accept it.

In my case, I goofed a little, and allowed git to convert the line endings to unix-style, as opposed to the windows-style you had before, so the entire file appears to be changed even though I did not make such sweeping changes. Nothing will break here, since it will be converted back for you as you check it out in Git for Windows, but it makes the pull request review very difficult.


Top
 Profile  
 
PostPosted: Thu Apr 06, 2017 12:06 pm 
Offline
User avatar

Joined: Sun Jan 22, 2012 12:03 pm
Posts: 5710
Location: Canada
Since we're talking about github etiquette, usually the onus is on the person making the pull request to provide an easily reviewable change. ;)

i.e. you should fix the line endings in your pull request branch, rather than requiring the puller to fix it.

Not that I think it matters or is a big deal in this specific case, but dougeff was asking about github etiquette.


Top
 Profile  
 
PostPosted: Thu Apr 06, 2017 12:19 pm 
Offline
User avatar

Joined: Sun May 27, 2012 8:43 pm
Posts: 1304
rainwarrior wrote:
Since we're talking about github etiquette, usually the onus is on the person making the pull request to provide an easily reviewable change. ;)

i.e. you should fix the line endings in your pull request branch, rather than requiring the puller to fix it.

Not that I think it matters or is a big deal in this specific case, but dougeff was asking about github etiquette.


Right, that's why I've acknowledged my mistake repeatedly, and worked on fixing it :?


Top
 Profile  
 
PostPosted: Thu Apr 06, 2017 12:58 pm 
Offline
User avatar

Joined: Sun Jan 22, 2012 12:03 pm
Posts: 5710
Location: Canada
Sorry, wasn't trying to cast shame on you or anything, I know you're fixing it, just wanted to illustrate the point about open source etiquette and thought it made a suitable example.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2

All times are UTC - 7 hours


Who is online

Users browsing this forum: Fisher and 8 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group