## WIP: Wizard of Wor

A place where you can keep others updated about your NES-related projects through screenshots, videos or information in general.

Moderator: Moderators

Omegamatrix
Posts: 35
Joined: Tue Jun 10, 2014 8:15 pm

### Re: WIP: Wizard of Wor

tschak909 wrote:The modulo is the problem here, given an integer divide by 24 such as:

Code: Select all

``````;; void __fastcall__ div24(unsigned char d);
_div24: lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr
rts
``````
How can I determine a modulo? Is it sitting here in temp at some point?

-Thom
Modulo is easy, there are a few ways to do it. You'll have to figure out how to integerate it into C though. Here's a few ways:

Long slow division does not take too long in this case as 24 is a big divisor.

Code: Select all

``````;24-94 cycles
_div24_mod24:
ldy   #\$FF
sec
_div24:
iny
sbc   #24
bcs   _div24
rts   ; Y = integer division result, A = modulo result``````
Using the unsigned integer division routine for div24, modulo24 can be found afterward with the help of a small look up table:

Code: Select all

``````;54 cycles
_div24_mod24:
pha   ; save original value

lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr

tay   ; integer division result
pla   ; get original value
sec
sbc   _multiply24,Y
rts   ; Y = integer division result, A = modulo result

_multiply24:
.db 0,24,48,72,96,120
.db 144,168,192,216,240``````
If you don't want to trash Y, you could just multiply by 24 instead of using a look up table.

Code: Select all

``````_div24_mod24:
pha   ; save original value

lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr
; C 76543210
sta   intDiv24  ; x 0000xxxx    integer division result (0-10 possible)

asl             ; 0 000xxxx0    x2
asl             ; 0 00xxxx00    x4
asl             ; 0 0xxxx000    x8
sta   TEMP
asl             ; 0 xxxx0000    x16 (carry is always clear at this point)
adc   TEMP      ;               x24
sta   TEMP
pla   ; get original value
sec
sbc   TEMP      ; A = modulo result, intDiv24 = integer division result
rts``````

Hope that helps!

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

Omegamatrix wrote:
tschak909 wrote:The modulo is the problem here, given an integer divide by 24 such as:

Code: Select all

``````;; void __fastcall__ div24(unsigned char d);
_div24: lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr
rts
``````
How can I determine a modulo? Is it sitting here in temp at some point?

-Thom
Modulo is easy, there are a few ways to do it. You'll have to figure out how to integerate it into C though. Here's a few ways:

Long slow division does not take too long in this case as 24 is a big divisor.

Code: Select all

``````;24-94 cycles
_div24_mod24:
ldy   #\$FF
sec
_div24:
iny
sbc   #24
bcs   _div24
rts   ; Y = integer division result, A = modulo result``````
Using the unsigned integer division routine for div24, modulo24 can be found afterward with the help of a small look up table:

Code: Select all

``````;54 cycles
_div24_mod24:
pha   ; save original value

lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr

tay   ; integer division result
pla   ; get original value
sec
sbc   _multiply24,Y
rts   ; Y = integer division result, A = modulo result

_multiply24:
.db 0,24,48,72,96,120
.db 144,168,192,216,240``````
If you don't want to trash Y, you could just multiply by 24 instead of using a look up table.

Code: Select all

``````_div24_mod24:
pha   ; save original value

lsr
lsr
lsr
sta   TEMP
lsr
lsr
ror
lsr
ror
lsr
; C 76543210
sta   intDiv24  ; x 0000xxxx    integer division result (0-10 possible)

asl             ; 0 000xxxx0    x2
asl             ; 0 00xxxx00    x4
asl             ; 0 0xxxx000    x8
sta   TEMP
asl             ; 0 xxxx0000    x16 (carry is always clear at this point)
adc   TEMP      ;               x24
sta   TEMP
pla   ; get original value
sec
sbc   TEMP      ; A = modulo result, intDiv24 = integer division result
rts``````

Hope that helps!
OMEGAMATRIX! How are you, man? Good to see you over here from AtariAge. I just signed up here for my first NES project.

also, thanks for the fast divide routines. They're great.

-Thom

Omegamatrix
Posts: 35
Joined: Tue Jun 10, 2014 8:15 pm

### Re: WIP: Wizard of Wor

I'm well. Looking for to see this homebrew develop.

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

I'm getting closer, I've attached a ROM of the current behavior. It mostly works except in certain cases I can still go through walls, and am trying to figure out why this is:

code snippets:

Code: Select all

``````/**
*/
{
// Change to idle state if pad is idle.
switch(stamps[STAMP_LAST_STATE(i)])
{
case STATE_PLAYER_RIGHT:
stamps[STAMP_STATE(i)]=STATE_PLAYER_RIGHT_IDLE;
break;
case STATE_PLAYER_LEFT:
stamps[STAMP_STATE(i)]=STATE_PLAYER_LEFT_IDLE;
break;
case STATE_PLAYER_UP:
stamps[STAMP_STATE(i)]=STATE_PLAYER_UP_IDLE;
break;
case STATE_PLAYER_DOWN:
stamps[STAMP_STATE(i)]=STATE_PLAYER_DOWN_IDLE;
break;
}
}

/**
* handle_player_in_field()
* Handle when player is on the playfield
*/
void handle_player_in_field(void)
{
if ((stamps[STAMP_X(i)]==PIXEL_BOX_X(a)) && (stamps[STAMP_Y(i)]==PIXEL_BOX_Y(b)))
{
// We are aligned.
if (PLAYER_PAD_RIGHT(i) && !BOX_WALL_RIGHT(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)]=STATE_PLAYER_RIGHT;
else if (PLAYER_PAD_LEFT(i) && !BOX_WALL_LEFT(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)]=STATE_PLAYER_LEFT;
else if (PLAYER_PAD_UP(i) && !BOX_WALL_UP(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(d)]=STATE_PLAYER_UP;
else if (PLAYER_PAD_DOWN(i) && !BOX_WALL_DOWN(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(d)]=STATE_PLAYER_DOWN;
}
else
{
// We are not aligned.
else if (PLAYER_PAD_RIGHT(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_LEFT)
stamps[STAMP_STATE(i)]=STATE_PLAYER_RIGHT;
else if (PLAYER_PAD_LEFT(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_RIGHT)
stamps[STAMP_STATE(i)]=STATE_PLAYER_LEFT;
else if (PLAYER_PAD_UP(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_DOWN)
stamps[STAMP_STATE(i)]=STATE_PLAYER_UP;
else if (PLAYER_PAD_DOWN(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_UP)
stamps[STAMP_STATE(i)]=STATE_PLAYER_DOWN;
else
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)];
}

// Handle state movement
if (stamps[STAMP_STATE(i)]==STATE_PLAYER_RIGHT)
stamps[STAMP_X(i)]++;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_LEFT)
stamps[STAMP_X(i)]--;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_UP)
stamps[STAMP_Y(i)]--;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_DOWN)
stamps[STAMP_Y(i)]++;

// And set last state, if we aren't idle.
stamps[STAMP_LAST_STATE(i)]=stamps[STAMP_STATE(i)];
}

/**
* handle_player_in_box()
* Handle when player is in box.
*/
void handle_player_in_box(void)
{
if (stamps[STAMP_XTRA_A(i)]>0)
{
if (stamps[STAMP_XTRA_B(i)] != 0)
{
stamps[STAMP_XTRA_A(i)]=0;
}
else
{
stamps[STAMP_Y(i)]=PIXEL_BOX_Y(6)-1; // 6 is the Y for the box.
if (sec==0) // 0 means approximately 1 second elapsed.
stamps[STAMP_XTRA_A(i)]--;         // Decrement timer
}
}
else
{
stamps[STAMP_Y(i)]=PIXEL_BOX_Y(5); // Pop out of box.
if (i==0)
{
yellow_door_state=CLOSED;
}
else
{
blue_door_state=CLOSED;
}
}
}

/**
* move_players()
*/
void move_players(void)
{
for (i=0;i<2;++i)
{
get_current_box();

if (stamps[STAMP_Y(i)]==PIXEL_BOX_Y(6)-1)
{
handle_player_in_box();
}
else
{
handle_player_in_field();
}
}
}
``````
Some vars:

a=the x coordinate for box cell (0-9)
b=the y coordinate for box cell (0-5)
c=the entry in the dungeon table to get the walls for that cell
d=the value pointed to by c

PIXEL_BOX_X converts a to a screen pixel coordinate using a multiply by 24 and adding a center bias, effectively aligning sprite in the center of box.

PIXEL_BOX_Y is the same for the Y coordinate in b.

BOX_WALL_* are macros that check for a given bit set in D for a wall present in cell d

I'm so freaking close, it's %(#@@#(%@# grrrrr... heeeeeelp!

Of course, the code is in github, but I'm attaching a binary rom here in case somebody can derive the errant behavior:
wow-better-player-collision.nes
-Thom

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

Adding this block in the aligned condition improves the collision detection to the point where I am no longer going through any walls, BUT, The player tries to change direction one box before the actual corner, which causes the player to not go through the wall, but hit the preceeding wall early and stop trying to round the corner. urgh...

Code: Select all

``````      if (PLAYER_PAD_RIGHT(i) && BOX_WALL_RIGHT(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_RIGHT_IDLE;
else if (PLAYER_PAD_LEFT(i) && BOX_WALL_LEFT(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_LEFT_IDLE;
else if (PLAYER_PAD_UP(i) && BOX_WALL_UP(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_UP_IDLE;
else if (PLAYER_PAD_DOWN(i) && BOX_WALL_DOWN(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_DOWN_IDLE;
``````
wow-better-player-coll-2.nes
Setting it to last state on each if, replicates the through wall behavior, so it looks like I need to dig into last state setting.

-Thom

rainwarrior
Posts: 7804
Joined: Sun Jan 22, 2012 12:03 pm
Contact:

### Re: WIP: Wizard of Wor

The lion-head enemies have a nice bounce to them.

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

rainwarrior wrote:The lion-head enemies have a nice bounce to them.
Thanks, I am doing occasional tests on a front loader attached to a cheapo AV upscaler which is just butchering the field output, and would love to see a pic of this running on a real CRT. The NTSC emulation in various emulators just doesn't feel right at all.

I will say that it is on my list that the monsters will all eventually have have random frame starts, so they aren't all skipping in unison, but right now, I am trying to get player to wall collision happening correctly. It's almost there. grrrrr...

-Thom

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

It's been quiet here, as I've been sidetracked on doing some Raspberry Pi work, but I'm continuing back on this, as soon as I hit a stopping point with the work I'm doing on the Pi.

-Thom

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

and I'm back. Motion solved with the following code (to be optimized):

Code: Select all

``````/**
* handle_player_in_field()
* Handle when player is on the playfield
*/
void handle_player_in_field(void)
{
if ((stamps[STAMP_X(i)]==PIXEL_BOX_X(a)) && (stamps[STAMP_Y(i)]==PIXEL_BOX_Y(b)))
{
// We are aligned.
if (PLAYER_PAD_RIGHT(i) && stamps[STAMP_LAST_STATE(i)] != STATE_PLAYER_RIGHT && !BOX_WALL_RIGHT(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)]=STATE_PLAYER_RIGHT;
else if (PLAYER_PAD_LEFT(i) && stamps[STAMP_LAST_STATE(i)] != STATE_PLAYER_LEFT && !BOX_WALL_LEFT(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)]=STATE_PLAYER_LEFT;
else if (PLAYER_PAD_UP(i) && stamps[STAMP_LAST_STATE(i)] != STATE_PLAYER_UP && !BOX_WALL_UP(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(d)]=STATE_PLAYER_UP;
else if (PLAYER_PAD_DOWN(i) && stamps[STAMP_LAST_STATE(i)] != STATE_PLAYER_DOWN && !BOX_WALL_DOWN(d))
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(d)]=STATE_PLAYER_DOWN;

if (stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_RIGHT && BOX_WALL_RIGHT(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_RIGHT_IDLE;
else if (stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_LEFT && BOX_WALL_LEFT(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_LEFT_IDLE;
else if (stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_UP && BOX_WALL_UP(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_UP_IDLE;
else if (stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_DOWN && BOX_WALL_DOWN(d))
stamps[STAMP_STATE(i)]=STATE_PLAYER_DOWN_IDLE;

}
else
{
// We are not aligned.
else if (PLAYER_PAD_RIGHT(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_LEFT)
stamps[STAMP_STATE(i)]=STATE_PLAYER_RIGHT;
else if (PLAYER_PAD_LEFT(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_RIGHT)
stamps[STAMP_STATE(i)]=STATE_PLAYER_LEFT;
else if (PLAYER_PAD_UP(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_DOWN)
stamps[STAMP_STATE(i)]=STATE_PLAYER_UP;
else if (PLAYER_PAD_DOWN(i) && stamps[STAMP_LAST_STATE(i)]==STATE_PLAYER_UP)
stamps[STAMP_STATE(i)]=STATE_PLAYER_DOWN;
else
stamps[STAMP_STATE(i)]=stamps[STAMP_LAST_STATE(i)];

}

// Handle state movement
if (stamps[STAMP_STATE(i)]==STATE_PLAYER_RIGHT)
stamps[STAMP_X(i)]+=2;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_LEFT)
stamps[STAMP_X(i)]-=2;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_UP)
stamps[STAMP_Y(i)]-=2;
else if (stamps[STAMP_STATE(i)]==STATE_PLAYER_DOWN)
stamps[STAMP_Y(i)]+=2;

// And set last state, if we aren't idle.
stamps[STAMP_LAST_STATE(i)]=stamps[STAMP_STATE(i)];
}
``````
Also merged in a new cfg file and Makefile courtesy of polluks, which will work on newer CC65 compilers after 2.15.

Latest ROM here:
wow-working-player-collision.nes
More to come shortly,
-Thom

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

is control okay for everybody? You should be able to move and round corners with ease. Let me know.

-Thom

lidnariq
Posts: 9305
Joined: Sun Apr 13, 2008 11:12 am
Location: Seattle

### Re: WIP: Wizard of Wor

Feels good to me. The bit where trying to walk into a wall makes you continue walking in the previous direction until you can turn strikes me as "surprising, but useful".

rainwarrior
Posts: 7804
Joined: Sun Jan 22, 2012 12:03 pm
Contact:

### Re: WIP: Wizard of Wor

It's good. I like that you can hold diagonal and it will alternate. That's exactly how I'd want/expect it to work.

The only thing that's maybe weird to me is if I press up just a little bit then stop, now pressing either left or right will move me upwards until the next grid, which feels a little weird, but maybe not something that needs to be addressed at all. (It's easy to learn this quirk, and it resolves itself pretty quickly anyway.)

Like I think I'd probably make it so that you can't stop moving between grid points, only reverse direction, so there's never a situation where you could have stopped just a little bit out of grid and have left/right forced to move up/down. I don't know if you'd want to do that, though, I presume the original game did not. That's just what I'd do, because it seems like walking a little bit out of the grid is already a commitment to move in that direction, might as well complete it?

Right now the sprite overlaps right-hand walls by one pixel.

Also kinda wish that my feet didn't always point right when going up/down but that also seems to be that way in the original? (I suppose it would make just as much sense to be able to walk upside-down as well, but that one doesn't feel "missing".)

Ejection from the starting point seems weird (immediate pop out, and then one frame of changed direction), but I'll assume that's something you haven't worked on yet.
Last edited by rainwarrior on Mon Sep 04, 2017 10:21 pm, edited 2 times in total.

Kasumi
Posts: 1292
Joined: Wed Apr 02, 2008 2:09 pm

### Re: WIP: Wizard of Wor

The rounding corners is quite fine.

But you've got some kind of serious glitch for the two players.

When player 2 changes to facing up or down, occasionally it affects player one. Let me know if you need an fm2 or something for debugging.

Edit: Oh, I appear to have missed the previous post saying there were problems with going through walls. Maybe the gif is useful for reproducing it, though.

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

WOW, that's a neat bug. I'll try to squash that today. Thanks for finding it!

-Thom

tschak909
Posts: 139
Joined: Mon Jul 03, 2017 4:37 pm
Contact:

### Re: WIP: Wizard of Wor

Ok, it has to be here, is there something stupid that I'm doing with regards to reading the player pads?

Code: Select all

``````/**
* move_players()
*/
void move_players(void)
{
for (i=0;i<2;++i)
{
get_current_box();