It is currently Sat Aug 18, 2018 5:57 am

All times are UTC - 7 hours



Forum rules


Related:



Post new topic Reply to topic  [ 201 posts ]  Go to page Previous  1 ... 10, 11, 12, 13, 14
Author Message
PostPosted: Thu Aug 09, 2018 9:56 am 
Offline

Joined: Sun Jul 22, 2018 2:36 pm
Posts: 7
Personally I have no major opinion on the timing of Qt5 integration, but I can give more information that may influence yours: Right now, to support JSON objects gracefully, I had to add an additional git submodule to the project to link in another JSON repo, and use the functionality that that provides. However, Qt5 provides a JSON system as well, that was absent from Qt4. If Qt5 is integrated before I prep a PR for the vscode work, I have no issue with supporting Qt5’s objects beforehand. If Qt5 is integrated after I prep a PR, then some work should be done after-the-fact to deprecate and remove the external JSON functionality I’m roping in. Aside from that it doesn’t affect me, really.


Top
 Profile  
 
PostPosted: Thu Aug 09, 2018 12:28 pm 
Offline

Joined: Sat Apr 25, 2015 1:47 pm
Posts: 407
Location: FL
That's a good point, and there isn't ever going to be a non-Qt5-based release that includes the new debugger GUI, so I'd probably consider working from (or merging) the qt5 branch if possible and working from there if possible.

(Also, if you're planning a pull request, please be aware that I'm not planning to merge benny's entire fork all at once at any point, and there will likely be commits from that fork which end up being omitted entirely, depending on how I feel about certain changes/features, so you'll probably end up needing to rebase your changes at some point in the future)


Top
 Profile  
 
PostPosted: Thu Aug 09, 2018 1:01 pm 
Offline

Joined: Sun Jul 22, 2018 2:36 pm
Posts: 7
Yeah, when I say "Based on" I mostly mean "I copied everything in disassembler/symbols and cleaned out some stuff that may not make sense in the immediate term but can be recuperated later" (e.g. breakpoints specified in the symbol files themselves, being able to write out new symbol files from the emulator). I'm not operating on the full fork or anything. There will be some collision of code, but it should not be too significant because most of the changes in that vein should be shared. Later on, when a PR is actually filed and let's say you haven't integrated any of benny's work, I can do a check to see how bad a resolve looks like if, say, all of that stuff had to come in - since that would be some work that you have to do ultimately - but that can be handled at the time, if that scenario comes to pass. Otherwise, if it comes to it that you integrate his work, I'm fine handling the resolves myself.


Top
 Profile  
 
PostPosted: Fri Aug 10, 2018 1:17 am 
Offline

Joined: Tue Feb 07, 2017 2:03 am
Posts: 515
CypherSignal wrote:
Yeah, tell me about it... Ironically, despite the frustrations in trying to shake down the various pages and documentation on this, furiously asking "What do you want from me?!?! :x :x " the answer ended up being rather simple - but obfuscated because of much of the intended utility all of the debug adapter extension shenanigans.
(snip)
Not yet shippable, and there's some stuff that's going to change as I go, but this is kind of the skeleton of it so far (note that ExternDebugHandler::processRequests is called as part of the Application::run tick, if you're wondering about the re-entry point of it all)

Awesome thanks.


Now we just need to get the newish debugger with a Windows binary ;) So one can see the WRAM as graphics ;)


Top
 Profile  
 
PostPosted: Fri Aug 10, 2018 9:07 am 
Offline

Joined: Sat Apr 25, 2015 1:47 pm
Posts: 407
Location: FL
The current release does already have support for showing WRAM (as part of the entire CPU address space) in the graphics viewer, if that helps.


Top
 Profile  
 
PostPosted: Fri Aug 10, 2018 9:14 am 
Offline

Joined: Tue Feb 07, 2017 2:03 am
Posts: 515
Ooo I missed the new release... indeed it does. AWESOME thanks.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 201 posts ]  Go to page Previous  1 ... 10, 11, 12, 13, 14

All times are UTC - 7 hours


Who is online

Users browsing this forum: LuigiBlood and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group